use Perl

• Re: Find the bug! (localize) (Score:1)

  by Corion (7288)

  As a lesson, you should always localize $_ and the other stuff when assigning to it...

  perl -le "sub _import{$_=shift};for('foo'){_import($class,$arg)}"
  • Re: (Score:1)

    by jplindstrom (594)

    Another lesson is to always. name. variables.
    • Re: (Score:1)

      by Aristotle (5147)

      Sorry, not gonna. Perl has $_ for a reason.
      • Re: (Score:0)

        by slanning (5049)

        The ultimate conquest of humanity by a species of intelligent rats?
        • Re: (Score:2)

          by Ovid (2709)

          At this point, I can't say we'd be that much worse off, except for the horrible programming language they would force us to standardize on [wikipedia.org].
• Modifying @_? (Score:1)

  by Smylers (2592)

  If # do stuff modifies $_ then foreach aliasing will try to modify the relevant entry in @_.

  That's unlikely to be desired, and I think will cause a crash if the caller passed a constant in.
  • Re: Modifying @_? (Score:1)

    by jarich (4909)

    Since the code is using while rather than foreach and more importantly shift rather than aliasing, this isn't going to be the bug in this code. When we shift, we copy, so changes (in this case) to $_ won't change @_.

    Having said that, I'd much prefer the original code to say:

    sub import {
        my $class = shift;
        foreach my $arg (@_) {
            # do stuff
        }
    }

    But then changing $arg would hit the problems you're thinking of.
    • Re: (Score:1)

      by Aristotle (5147)

      for my $arg (my @copy = @_) { ... }
    • Re: (Score:1)

      by Smylers (2592)

      the code is using while rather than foreach

      Hmmmm, clearly I can't read! Ooops.