use Perl

• Passing hashref to constructor (Score:1)

  by melo (332) on 2007.09.04 5:10 (#57405) Homepage Journal

  Hi, regarding

  Further, Object::Tiny lets you pass your params in directly, without having to wrap them in an additional HASH reference that will just be copied ANYWAY inside the constructor.

  and

  Object::Tiny accessors are identical in speed to Class::Accessor::Fast accessors, but Object::Tiny constructors are TWICE as fast as Class::Accessor::Fast constructors, DESPITE C:A:Fast forcing you to pass by reference (which is typically done for speed reasons).

  Speed is not the only reason, and I believe its not the mains reason even.

  My reason to always pass hashrefs is that if I leave out one of the arguments, the error message from perl will tell me the exact line number where I made the mistake, and not the line inside your constructor where you assign @_ to an hash (the common approach).

  Having said that, if your constructor checks for a even number of parameters and croaks (or Carp::Clan croaks), then the message will show the correct line number again.

  I haven't check the Object::Tiny yet, but I will. And this will probably the first think I'll look for :)

  The module looks great BTW.

  --
  life is short

  Reply to This

  • Re: (Score:1)

    by mr_bean (3802)

    ..the error message from perl will tell me the exact
          line number where I made the mistake, and not the line inside your
          constructor where you assign @_ to an hash (the common approach).
    
    That's what Perl Best Practices recommends too, I think,
    although it looks terrible.
    • Re: (Score:1)

      by melo (332)

      Yes it is... As for the syntax, it grows on you.
      
      But truth be told, there is no need to use that trick to get the proper error line. If module authors that accept hashes add this line:
      
          croak('FATAL: odd number of parameters, ') if @_ % 2;
      
      (Use Carp qw( croak ) at the top also)
      
      It would also work.
      
      Best regards,

      --
      life is short