use Perl

• Code smell heuristic (Score:2)

  by jdavidb (1361)

  conditional checks in OO code prove themselves to be code smells.

  Thanks for the heuristic! I never realized that before! I think this will help improve my coding.

  (If there's a larger source where you picked that up, I'd be benefitted by a pointer.)

  --
  J. David works really hard, has a passion for writing good software, and knows many of the world's best Perl programmers
  • Re: (Score:2)

    by Ovid (2709)

    I figured a concrete example would help. Imagine this awful method from some Catalyst code I was working on:

    sub _set_group_by : Private {
        my ( $self, $c ) = @_;
        my $group_by = 'day';
        my $period = $c->stash->{report_metadata}{period};
    
        my $report_range
                = $c->stash->{report_metadata}{start}->day_month_year
                . ' – '
             
    • Re: (Score:1)

      by jplindstrom (594)

      Remove duplication. Name things. These things go together.
      
      Look at the method names. Do they really focus on what the methods do? Where is the axis of duplication? (hint: group by)
      
      • Re:Code smell heuristic (Score:2)

        by Ovid (2709) on 2008.04.29 16:35 (#62482) Homepage Journal

        This was a tiny example and merely a first-pass refactor. If you look at the actual code I checked in, you'll see it's much cleaner.

        Reply to This

        Parent