use Perl

• premature optimisation? (Score:2)

  by nicholas (3034) <nwc10+useperl@colon.colondot.net> on 2004.10.11 15:22 (#35110) Homepage Journal

  Personally I'd put the initialisation of %rev_types outside the subroutine (but inside anther block to limit the scope) to avoid initialising it each time through the subroutine. But this may well smack of premature optimisation. Then again, it makes it clear that it's a constant structure.

  Reply to This

  • Re:premature optimisation? (Score:2)

    by Ovid (2709)

    No, you're right. I should "use constant ..." to make it clear what's going on. Whenever I do a quick refactoring in place, I try to limit the changes. Sometimes that means I wind up not changing enough.
  • Re:premature optimisation? (Score:1)

    by jplindstrom (594)

    I usually do that too.
    
    But beware. Sometimes that practise bites me when I eventually implement a class, not in it's own .pm file like I usually do, but just by switching package in the .pl file. So the variable initialization doesn't happen until afterwards and I end up with an empty data structure.
    
    And there is much confusion.
    • Re:premature optimisation? (Score:1)

      by Aristotle (5147)

      That's why you should do declaration and initialization in separate steps, and wrap the initialization with a BEGIN.

      {
          my %dispatch;
          BEGIN {
               %dispatch = (
                   foo => sub { ... },
                   bar => sub { ... },
                   baz => sub { ... },
               );
          }
      
          sub quux {