use Perl

• In all fairness (Score:1)

  by Aristotle (5147)

  The original code doesn’t make it obvious whether anything should be returned or not. Putting in an explicit return – assuming, of course, that you put it in the right place – definitely improves the code.
  • Re: (Score:1)

    by waltman (335)

    Perhaps that argument might be true for a longer, more complicated subroutine. I agree that implicit returns can be confusing. Perhaps a better standard would be to ban them instead of requiring unnecessary return statements. Then it would be clear that a this function doesn't return anything useful.
    
    I'll also note that rjbs didn't say what the subroutine's documentation says. Maybe it reads "Prepares a report and saves it in $file. Doesn't return a damn thing."
    
    • Re: (Score:2)

      by jonasbn (1153)

      The good thing about Perl::Critic, is that it make you think about your code, so you do not just put or leave out statements by habit.
      
      I have just finished a project for a client, I have disabled 8 policies and have documented as to why I have done so in the POD.
      
      So disable the policy and document it

      [-Subroutines::RequireFinalReturn]
      • Re:In all fairness (Score:1)

        by rjbs (4671) on 2007.10.22 8:06 (#58514) Homepage Journal

        Absolutely! I love Perl::Critic, and have written my own policies to remind me to think about stuff. I suggest Perl::Critic readily -- as a diagnostic tool, not as a master.

        --
        rjbs

        Reply to This

        Parent