Stories
Slash Boxes
Comments
NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

All the Perl that's Practical to Extract and Report

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
 Full
 Abbreviated
 Hidden
More | Login | Reply
Loading... please wait.
  • He came up with the same basic algorithm I did: [snip]

    Ah, clever. Especially step 4.

    As for your patch, I think you can completely delete "if (!&tmbuf) RETPUSHUNDEF", and replace "else if (&tmbuf)" with "else", since now your tmbuf struct will always be there -- it's not a pointer returned from a function which can be NULL on error. In fact, those functions don't seem to have an error check (except for the asserts in _check_tm).
    --

    -- 
    Esli epei eto cumprenan, shris soa Sfaha.
    Aettot ibrec epesecoth, spakhea scrifeteis.

    • Yes, step four solved a large number of problems and made it much more efficient and accurate. The original 2038bug code wrote it's own 64 bit clean mktime() and was running it through that several times to get offsets and the dst information was wrong, all sorts of minor inaccuracies. But #3, picking the right safe year, was what consumed the most time.

      Don't look to hard at the perl patch, it was done in 5 minutes so that I'd have a working miniperl to point at. There's all sorts of configure and system