use Perl

• why the "if" clause? (Score:1)

  by thepler (6873)

  $log->debug("a debug message") if $log->is_debug();

  I'm not sure why you want the "if" clause. I'd prefer to have the debug method just do nothing unless debugging is enabled. If you're trying to avoid a method call, you'd want:

  $log->debug("a debug message") if $is_debug;

  though personally I'd just prefer:

  $log->debug("a debug message");
  • Re:why the "if" clause? (Score:1)

    by jonswar (7880) <swartz@pobox.com> on 2007.09.07 22:37 (#57615) Journal

    You're right, that was a poorly chosen example. Yes, $log->debug() won't do anything unless debugging was enabled. Here's a more appropriate use of the conditional:
    
            $log->debug("current args: " . Dumper(\@_))
                  if $log->is_debug();
    
    The idea is to use the conditional when you don't want to compute the arguments (in this case, Dumper()) unnecessarily.
    

    Reply to This

    Parent

    • Re: (Score:1)

      by thepler (6873)

      I seem to recall that one of the other logging modules (I forget which) uses a sub for that.

      $log->debug(sub {"current args: " . Dumper(\@_)});