Stories
Slash Boxes
Comments

NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

use Perl

All the Perl that's Practical to Extract and Report

Painful, painful bug More | Login | Reply

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.

Without JavaScript enabled, you might want to use the classic discussion system instead. If you login, you can remember this preference.

Perl::Critic (Score:1)

by ChrisDolan (2855)

Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars [cpan.org] to the rescue!
- Re:Perl::Critic (Score:1)
  
  by jplindstrom (594) on 2008.06.25 8:09 (#63610) Journal
  
  That's not quite what this is about. The problem is that $@ gets set to undef whenever an eval runs successfully, eradicating the current exception object before it can get handled by reaching the intended eval.
  The critic rule would be to always require
  
  DESTROY { local $@; ... }
  
  where ... either contains an eval BLOCK, or a sub call which could potentially involve an eval BLOCK. A bit pedantic perhaps, but probably worth it since the alternative is to risk silencing exceptions!.
  Of course other global vars could be problematic in the same way, but $@ is in an especially weak position since it's involved in flow control.
  
  Reply to This
  
  Parent

Get More Comments

Stories, comments, journals, and other submissions on use Perl; are Copyright 1998-2006, their respective owners.