use Perl

• Hmmm. (Score:1)

  by Abigail (26)

  Is that really a mistake? Seems to me that 'validate' is a function that validates strings. It just so happens that in this call it needs to validate the result of a method that was called on the same object.

  It's a trade-off. If you write 'validate' such that it doesn't take argument, but calls 'user' on its first parameter, you have a function with a simpler interface. OTOH, the function is less general than it can be - all it can do is validate its own user. It also should have been named differently, f
  • Re:Hmmm. (Score:2)

    by Ovid (2709) on 2006.09.29 11:26 (#50582) Homepage Journal

    I shouldn't have called it 'validate'. I guess that was a red herring. My boss has given me permission to sometimes post code snippets so long as I make it clear it's code being cleaned up and that I don't reveal any business knowledge. As a result, I really can't post more context. In this case, it was closer to something like this (still anonymous, but closer in intent):

    sub _post_to_website {
        my ($self, $user) = @_;
        my $lwp = LWP::UserAgent->new;
        ...
    }
    
    # and the actual call
    $self->_post_to_website( $self->{username} ); # reaching into the object

    There was no validation of the username. The username is required to be the object's username in order for the POST to succeed.

    Reply to This

    Parent