use Perl

• Too much work (Score:2)

  by brian_d_foy (44) <brian.d.foy@gmail.com> on 2008.04.30 1:02 (#62494) Homepage Journal

  Shouldn't you get rid of the conditional with ->log? Just let the method figure out what to do. And where did $debug come from? Shouldn't that be a method call? :)

  Reply to This

  • Re: (Score:2)

    by Ovid (2709)

    The conditional is a point I make in my OO guidelines writeup [perlmonks.org] on PM. It's bad practice. I make the same point here, too [perl.org]. So yes, I do agree with you, but I plead mea culpa of posting a bad example to explain good code ;)
    • Re: (Score:1)

      by hanekomu (8123)

      You could get rid of the "if ($debug) { $self->log(...) }" by using Class::Null [cpan.org]. That is, the log object (assuming it's an object) should be Class::Null by default and a real logging object if $debug is set. Then just do "$self->log(...)" without the conditional, and if it's a Class::Null object, the call is more or less ignored. The documentation of Class::Null actually uses this example.