use Perl

• Feedback (Score:2)

  by jonasbn (1153)

  As the author of Module::Template::Setup, could you please tell me why you did not choose Module::Template::Setup. I would very much like to know if there is something I need to change. Not so much module-wise but perhaps more in my coding style.
  
  Well if you have the time anyway :)
  • Re:Feedback (Score:1)

    by rjbs (4671) on 2004.07.23 19:02 (#32807) Homepage Journal

    Don't I feel silly for saying Module::Setup::Template over and over? (I do.)
    
    I'm not sure I could really say specifically what it was. I think part of it was the lines in new() that assign to $self's defaults. There are four pairs of lines that are very similar, which always makes me uncomfortable, especially if I'm just skimming. That occurs again in _get_data. I think that was probably the brunt of it.
    
    I didn't spend a lot of time making this decision. ;)
    
    I think there are definitely ways in which MTS is cleaner than MS was, and in some ways MS is going to have to remain weird inside for a while, until MS::Simple can be rewritten a little.
    
    Anyway, as to the repeated similarity thing, do you see what I mean? In working on some things in code left behind here, by a coworker, I saw the same thing a few times, and every time it correctly signalled refactorability. I'm not sure if that's the case in MTS, but that's part of what jarred me.

    --
    rjbs

    Reply to This

    Parent

    • Re:Feedback (Score:2)

      by jonasbn (1153)

      Oh, great, well I know a refactoring is necessary at some point, but since I am not completely satisfied with the current state of MTS I have not thought about making a refactoring yet.
      
      I need to get the installation proces going correctly. When this part works I would consider MTS to have met the initial goals.
      
      After this a refactoring is will probably be a good thing.
      
      Thanks for the great feedback...