use Perl

• success (Score:1)

  by TorgoX (1933)

  You forgot to check whether the get() succeeded!

  In LWP OO terms:

  use LWP;
  my $resp = LWP::UserAgent->new->get($url);
  die "GRAH! ", $resp->status_line unless $resp->is_success;
  ... HTML::TokeParser->new( $resp->content_ref ) ...
  • Re:success (Score:1)

    by exeunt (319)

    I get this now (with your modifications):
    
    Can't locate object method "get" via package "LWP::UserAgent"
(perhaps you forgot to load "LWP::UserAgent"?) at HTML/TokeParser/URL.pm line 18.
    
    • Re:success (Score:1)

      by TorgoX (1933)

      Upgrade your LWP!
      • Re:success (Score:1)

        by exeunt (319)

        This is on a windows machine, ActivePerl 631. In PPM I see no where to update LWP/libwww-perl. In PPM3 it shows libwww-perl 5.51 as up to date.
        
        I guess I could manualy upgrade it manualy.
        
        I did check this on a FreeBSD box, and it works! Thanks for the suggestion.
        
        • Re:success (Score:1)

          by TorgoX (1933)

          Or just do $browser->request(HTTP::Request->new(GET=>$url)) instead of $browser->get($url)
          • Re:success (Score:1)

            by exeunt (319) <reversethis-{ten.xyz} {ta} {izaguf}> on 2002.03.20 17:00 (#6179) Journal

            I like this approch, since it will now work on older versions of LWP. (In a perfect world backward compatibility would not be known).
            
            Thanks for your help.

            Reply to This

            Parent

            • Re:success (Score:1)

              by TorgoX (1933)

              I shouldn't pass up this chance to say that there are certain security problems with older LWP dists; but if you just don't use them in a CGI, you're fine.