use Perl

• Hmmm. (Score:1)

  by Abigail (26)

  Is that really a mistake? Seems to me that 'validate' is a function that validates strings. It just so happens that in this call it needs to validate the result of a method that was called on the same object.

  It's a trade-off. If you write 'validate' such that it doesn't take argument, but calls 'user' on its first parameter, you have a function with a simpler interface. OTOH, the function is less general than it can be - all it can do is validate its own user. It also should have been named differently, f
  • Re:Hmmm. (Score:1)

    by markjugg (792) <reversethis-{moc ... mus} {ta} {kram}> on 2006.09.29 19:37 (#50602) Homepage Journal

    I agree with Abigail. Explicit argument passing makes it clearer what happening, and can make the code more re-usable.
    
    A methodology of sticking everything thing in the object and then referencing it there is a close cousin to the evilness that is global variables.
    
    However, if you code is full of $self->user always being passed to $self->validate.... there could be a problem.
    
    

    Reply to This

    Parent