use Perl

• Some nits to pick (Score:2)

  by autarch (914)

  Generally, I think this is a good idea, but I have some nits to pick.
  
  First, the set_logger() method is not actually setting a logger at all, which is confusing. It's setting a callback that returns a logger, so maybe it should be set_logger_factory() or something like that. This is particularly problematic since there's a get_logger() method, which doesn't return the thing passed to set_logger()!
  
  I'm not sure that passing in a sub ref is the best API either. My gut feeling is that "the average programmer" is
  • Re: (Score:1)

    by fireartist (6128)

    I got the impression that all CPAN modules should use the logging interface, but not set any logger themselves.
    So the only place the logger would be set would be in your 'top level' application, or framework (catalyst, jifty, etc).
    • Re:Some nits to pick (Score:1)

      by jonswar (7880) <swartz@pobox.com> on 2007.09.07 13:14 (#57601) Journal

      That's exactly right. Since the setting of Log::Abstract is (by design) global across the application, it would be considered bad behavior for an arbitrary CPAN module to muck with it, in the same way it would be bad behavior to unset $^W, or clear @ARGV, or read from STDIN - unless that was part of the proscribed behavior of the module.
      

      Reply to This

      Parent