Stories
Slash Boxes
Comments
NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

All the Perl that's Practical to Extract and Report

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
 Full
 Abbreviated
 Hidden
More | Login | Reply
Loading... please wait.
  • by Abigail (26) on 2006.09.29 10:12 (#50576) Journal
    Is that really a mistake? Seems to me that 'validate' is a function that validates strings. It just so happens that in this call it needs to validate the result of a method that was called on the same object.

    It's a trade-off. If you write 'validate' such that it doesn't take argument, but calls 'user' on its first parameter, you have a function with a simpler interface. OTOH, the function is less general than it can be - all it can do is validate its own user. It also should have been named differently, for instance 'validate_user'.

    Now, for the program you lifted this statement of, it might have made more sense to have a method that just calls 'user' on its first parameter. But if all I'm shown is the given statement, I won't judge it to be right or wrong.

    • I shouldn't have called it 'validate'. I guess that was a red herring. My boss has given me permission to sometimes post code snippets so long as I make it clear it's code being cleaned up and that I don't reveal any business knowledge. As a result, I really can't post more context. In this case, it was closer to something like this (still anonymous, but closer in intent):

      sub _post_to_website {
          my ($self, $user) = @_;
          my $lwp = LWP::UserAgent->new;
          ...
      }

      # and

    • I agree with Abigail. Explicit argument passing makes it clearer what happening, and can make the code more re-usable.

      A methodology of sticking everything thing in the object and then referencing it there is a close cousin to the evilness that is global variables.

      However, if you code is full of $self->user always being passed to $self->validate.... there could be a problem.