NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.
All the Perl that's Practical to Extract and Report
--Donald E. Knuth
Stories, comments, journals, and other submissions on use Perl; are Copyright 1998-2006, their respective owners.
Okay author of MooseX::Types::Structured listening (Score:1)
Waiting on the Road to Eventually, I lost my Place On Line
Reply to This
Re: (Score:2)
In your Makefile.PL change..
..to..
You already have the appropriate eval/skip in both respective test files.
Re: (Score:1)
Waiting on the Road to Eventually, I lost my Place On Line
Re: (Score:1)
Actually, it shouldn't be in recommends either.
Firstly, recommends isn't actually implemented.
Secondly, once the META.yml upgrade process does reach the point of dealing with this, it's likely to mean either "Should be installed for all users except in resource-constrained environment" or possibly "Enhances the run-time functionality of the module".
Re: (Score:2)
Should there be a build_recommends then? Although I don't reference them in my Makefile.PL, I do reference them in the 'recommends' section of my META.yml. I'd rather mention them somewhere, in the event that someone might be interested :)
Re: (Score:1)
Waiting on the Road to Eventually, I lost my Place On Line
Re: (Score:1)
1. Remove all mention of the author test modules from META.yml
2. As a bonus, you can change pod.t to something like this
#!/usr/bin/perl
# Test that the syntax of our POD documentation is validuse strict;
BEGIN {
$| = 1;
$^W = 1;
}
my @MODULES = ('Pod::Simple 3.07',
'Test::Pod 1.26',
);
# Don't run tests during end-user installsuse Test::More;
unless ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} )
Blargh (Score:1)
Speaking of cargo-cult code....
Re: (Score:1)
It's good enough until Module::Install (and other things) have built in xt support
Re: (Score:1)
Waiting on the Road to Eventually, I lost my Place On Line
Re: (Score:1)
You remove it manually from the Makefile.PL so it's removed automatically from the META.yml.
Re: (Score:1)
I realize you are only suggesting this for the pod tests. For those tests, this is innocuous enough. However, as chromatic pointed out, cargo cult programming exists. I'd prefer to give the cargo cult programmers as few chances to happen across code that skips all tests for people installing via CPAN/CPANPLUS, especially since some of them may not run any tests on their own boxes (even though they have them.)
Re: (Score:1)
You prefer to prioritise the people that would copy and paste author tests into their own modules ahead of everyone everywhere that installs modules for any reason at all?
That seems like prioritising a small group with a rare situation ahead of an enormous group with common situation.