use Perl

• Drawing the line (Score:1)

  by robin (1821)

  You're right that different people will draw the line in different places. I think that the original is actually better code, because it's immediately obvious what it does. The refactored version requires a bit of “decoding”.

  The important thing is that you’re thinking about it rather than just refactoring it because you can. (And I guess that this example must be close to your own borderline, or you wouldn't be asking about it.)
  • Re:Drawing the line (Score:2)

    by djberg96 (2603) on 2005.12.04 11:34 (#44982) Journal

    I agree that the original is better as well, unless the refactored version is significantly faster somehow (and that's an oft repeated operation).

    Reply to This

    Parent

    • Re:Drawing the line (Score:2)

      by Theory (10)

      Thirded. The new version is much more abstract for no really good reason that I could see.
      
      —Theory
      • Re:Drawing the line (Score:1)

        by ChrisDolan (2855)

        Fourthed. The second version is worse for searchability -- say, if I want to find all instances of "delete_for_class" in my code.
        
        • Re: (Score:1)

          by Aristotle (5147)

          Only if he actually composes them as strings. The version I posted [perl.org] has the clever bits save for interpolation, and searchability wouldn’t suffer with it.
      • Re:Drawing the line (Score:2)

        by malte (1708)

        Fifthed: You shouldn't put method names in vars unless you absolutely have to.