use Perl

• Make use warnings a full kwalitee point (Score:1)

  by Alias (5735) on 2007.10.30 18:53 (#58676) Homepage Journal

  Here's what I'd recommend doing.
  
  Firstly, you need a new "has_perl_version" test.
  
  This would check that the distribution explicitly declares (presumably in it's META.yml) the version of perl that the distribution depends on.
  
  Secondly, once you have that in place, make the use warnings logic something like...

  if ( dist needs 5.6+ ) {
      if ( has_warnings ) {
          return pass;
      } else {
          return fail;
      }
  } else {
      return pass;
  }

  That is, you should only fail the use warnings kwalitee metric IF you can guarantee the 100% of the userbase can handle use warnings.
  
  (and we've needed the has_perl_version metric for a while anyways)

  Reply to This