use Perl

• Redundant run{...} (Score:1)

  by audreyt (6654)

  Static rules such as:

  before '*' => run { set object_type => 'account' };
  
  on '/' => run { show 'crud/index' };

  Can be written instead as:

  before '*' => set object_type => 'account';
  
  on '/' => show 'crud/index';

  it's a bit more declarative that way. :-)
  • Redundant qr{...} (Score:1)

    by audreyt (6654)

    Also, with our extended glob syntax one can replace:

    before qr'/(.*?)/(.*)' => run { set id => $2; };

    with this:

    before '**/*' => run { set id => $2; };

    With both changes in place, it'd look like this:

    under '/admin/account' => run {
        before '*'    => set object_type => 'account';
        before '**/*' => run { set id => $2 };
    
        on '/'         => show 'crud/index';
        on '/list'     => s
    • Re: (Score:2)

      by jesse (2531)

      Sorry. I changed some things out from under you. oops.
• Small suggestion (Score:1)

  by sri (5109)

  Me likes, but you might want to extend your globs a bit.
  Range and hash support could make it look even better.

  before qr'/(\d+)' => run { set id => $1; };

  could become

  # hash, equivalent to /(\d+)
before '/#' => run { set id => $1 }

# range, for more specific matching (bit more complicated to implement but worth it imo)
before '/[0-255]' => run { set id => $1 }

# alternatives, would make sense too :)
before '/{1|133|255}' => run { set id => $1 }
  • Re: (Score:2)

    by jesse (2531)

    It's an interesting thought. Though once we get to ranges, it's almost easier to just use full regexps. (And everywhere we use globs, we can just use a full regexp and qr'' instead. Globs are really nice for the simple case. I'm not quite sure where to draw the line. But "#" feels really nice. The suggestion is much appreciated.
  • Re: (Score:1)

    by audreyt (6654)

    We already support the standard glob syntax:

    before '{1,133,255}'

    As well as character classes:

    before '[a-z]'

    So I'm afraid that numeric range needs some other syntax. The '#' shorthand is very nice, though. :-)
    • Re: (Score:1)

      by sri (5109)

      Ah, nice one, been some time since i last looked at Jifty::Dispatcher. :)
      • Re: (Score:1)

        by audreyt (6654)

        ----------------------------------------------------------------------
        r25678 (orig r2238):  audreyt | 2006-12-01 12:43:40 +0800
        
        * Jifty::Dispatcher - NUMBER SIGN (#) now captures one or more digit
          characters in the extended shellglob condition syntax.
          Suggested by: Sebastian Riedel
        ----------------------------------------------------------------------