use Perl

• extra concats (Score:1)

  by pmichaud (6013)

  ...One idiom jumped out at me:
          $S0 = concat "PIR", ':"'

  Interesting -- apparently PGE is generating these concat statements whenever there is PIR embedded in a rule. For example:

  
token MARK_STATEMENT_END {
        {{ $P0 = match.'to'()
                $P0 = clone $P0
                set_global '$!endstmt', $P0
        }}
        <.ws>
}
  • Re:extra concats (Score:1)

    by pmichaud (6013) on 2008.04.21 10:11 (#62321) Homepage Journal

    Based on chromatic's analysis I re-examined the section of PGE that was responsible for generating the concats in the first place, and nearly all of the concatenations it was performing at runtime were constants that could be done at compile-time. I must've been asleep when writing that code.
    
    So, I refactored the code to avoid the concats altogether, and building rakudo's actions.pl file is now 1.6% faster than it was before (44.363 versus 45.095 seconds on my box). Not a huge speedup, but I'm still happier knowing that we aren't doing a lot of unnecessary and repeated concat operations -- especially since they were in code that gets called a lot (such as when scanning over whitespace and comments).
    
    Thanks for the analysis and updates.
    
    Pm
    
    

    Reply to This

    Parent

    • Re: (Score:1)

      by Aristotle (5147)

      Suggestion: more people will see this if you post it to your own journal. :-)