NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.
All the Perl that's Practical to Extract and Report
about I/O disciplines and I should retire to the Tassili-in-Aijer
mountains in Sahara as a camel herder :-)
-- Jarkko Hietaniemi
Stories, comments, journals, and other submissions on use Perl; are Copyright 1998-2006, their respective owners.
Some nits to pick (Score:2)
First, the
set_logger()method is not actually setting a logger at all, which is confusing. It's setting a callback that returns a logger, so maybe it should beset_logger_factory()or something like that. This is particularly problematic since there's aget_logger()method, which doesn't return the thing passed toset_logger()!I'm not sure that passing in a sub ref is the best API either. My gut feeling is that "the average programmer" is
Re: (Score:1)
> confusing. It's setting a callback that returns a logger, so maybe it should be
> set_logger_factory() or something like that. This is particularly problematic since
> there's a get_logger() method, which doesn't return the thing passed to set_logger()!
You're right, set_logger() should be renamed, though I'm not sure I can bear to use "factory".
>
> I'm not sure that passing in a sub ref is the best API eith
Re:Some nits to pick (Score:1)
The name you are looking for is
register_logger.Reply to This
Parent