use Perl

• Proof Built Right In! (Score:2)

  by krellis (2720) <reversethis-{gro.sillerk} {ta} {mit}> on 2004.03.07 14:59 (#29178) Homepage Journal

  You've built proof of your point right into your examples for the second worst variable name ever. Your renamed code is not functionally identical to the original. You've replaced $total with $payable_total when it should have been replaced by $order_total. Specifically, this:

  $total2 += $total * $taxrate;

  should translate to:

  $payable_total += $order_total * $taxrate;

  rather than

  $payable_total += $payable_total * $taxrate;

  Hence proving why numbered variables are EVIL!

  Reply to This

  • Re:Proof Built Right In! (Score:1)

    by echo (2881)

    It only proves that modifying code just because you think the variable names aren't right, is wrong! If it ain't broken...
    
    PS: not that I think that $total2 is a good variable name!
    • Re:Proof Built Right In! (Score:1)

      by pdcawley (485)

      Actually, it proves that you should ideally change the variable names using a tool that will change all uses of a given variable correctly. It further demonstrates that you should have a test suite which you run each time you change a variable, and roll back the changes if the test suddenly starts failing.