Stories
Slash Boxes
Comments

NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

use Perl

All the Perl that's Practical to Extract and Report

Refactoring into oblivion More | Login | Reply

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.

Without JavaScript enabled, you might want to use the classic discussion system instead. If you login, you can remember this preference.

Drawing the line (Score:1)

by robin (1821)

You're right that different people will draw the line in different places. I think that the original is actually better code, because it's immediately obvious what it does. The refactored version requires a bit of “decoding”.
The important thing is that you’re thinking about it rather than just refactoring it because you can. (And I guess that this example must be close to your own borderline, or you wouldn't be asking about it.)
- Re:Drawing the line (Score:2)
  
  by djberg96 (2603)
  
  I agree that the original is better as well, unless the refactored version is significantly faster somehow (and that's an oft repeated operation).
  - Re:Drawing the line (Score:2)
    
    by Theory (10)
    
    Thirded. The new version is much more abstract for no really good reason that I could see.
    
    —Theory
    - Re:Drawing the line (Score:2)
      
      by malte (1708) on 2005.12.04 14:40 (#44987) Homepage Journal
      
      Fifthed: You shouldn't put method names in vars unless you absolutely have to.
      
      Reply to This
      
      Parent

Get More Comments

Stories, comments, journals, and other submissions on use Perl; are Copyright 1998-2006, their respective owners.