NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.
All the Perl that's Practical to Extract and Report
Stories, comments, journals, and other submissions on use Perl; are Copyright 1998-2006, their respective owners.
Maybe, but that commit is a bad one (Score:2)
That commit threw out a lot of useful information. When someone comments "I don't know what this fucking function is doing when I call it", the confusion is important.
If you think that having "naughty" words is not okay in your source, fine (thanks, nanny). But please don't remove useful information just to delete the f-word.
Re:Maybe, but that commit is a bad one (Score:1)
I agree with the sentiment of the committer, but I also agree that the commit has thrown out useful information. Removing comments which at least give the reader an understanding of what's the author was thinking, just seems weird. Rewriting them would have been fine (and is what happened for most of them). As an example, the code goes from having the following:
which at least tells the reader why continue is called at that point, to being:
Which looks bizarre... why do we continue? Why would pmi be NULL?
Reply to This
Parent