Stories
Slash Boxes
Comments
NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

All the Perl that's Practical to Extract and Report

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
 Full
 Abbreviated
 Hidden
More | Login | Reply
Loading... please wait.
  • by belg4mit (967) on 2006.12.17 11:19 (#52341) Homepage Journal
    Well, the test suite wasn't especially helpful given the dependencies (in particular Module::Build failed three or four different ways on two different platforms for me). Believe it or not, I did in fact try various things after "commenting out random code" (it's a little too specific to actually be random). And although I cannot duplicate the results now, I seem to recall tan() somehow magicaly working work just fine last night. In any event, yes, tan() is just sin()/cos() and anyone using this module ought to know that already; esp. if they're anglophones and the SoaCahToa bit doesn't jog their memory. So, I feel you're probably being just a tad hypersensitive here. I will of course, change the "comment out these 3 superflous lines to" "patch them with this slightly less superfluous line." As for forwarding bug reports, it might be more productive to tidy up the code? Either "more elegant" or "fewer extraneous dependencies."
    --
    Were that I say, pancakes?
    • Entry ammended.
      --
      Were that I say, pancakes?
    • I also happen to get many failed tests regardless of the inclusion of tan (32 with, 33 without), so "The test suite is failing all over the place because you have just removed the implementation of the tangent function!", is a bit of an exaggeration. See RT [cpan.org].
      --
      Were that I say, pancakes?
    • I have a couple of things to note. I'm a hurry, so please forgive me if I jot them down in a list:

      - Please try Number::WithError 0.08 which is on its way to CPAN now. It fixes the bug that would make the constructor tests fail if Math::Symbolic wasn't loaded. Why the tests didn't fail if M::S was loaded is completely opaque to me, but the problem was related to (non) stringification of Math::BigFloat objects.

      - That release also removes any dependency on Math::Symbolic*.

      - How is this related to Module::Build
      • * Re: try Will do

        * Re: M::B it doesn't always fail, and not in those ways. How does it relate? All of the build and test errors desensitized me to those that followed. Besides, how seriously do most people take test failures? It's usually a judgement call (80%+ success seems pretty good) since they all have the same weight (that might be an interesting extension... bumps and bruises vs. core meltdown)

        * Re: SOACAHTOA Yes, it's a mnemonic for learning gemoetric relationships of a triangle's sides and angles.

        *
        --
        Were that I say, pancakes?