use Perl

• Re: cheap profiler (Score:1)

  by jplindstrom (594)

  For clarity and brevity you can rewrite

  $form .= $args->{'hidden'} if $args->{'hidden'};

  as

  $form .= $args{'hidden'} || "";

  If the value of $args{'hidden'} evaluates to false, "" is used instead, and the undef value isn't used for concatenation.
  
  But note that 0 evaluates to false, so if you expect that as a legit value of $args{'hidden'}, this won't work.
  
  The new defined-or ( // instead of || ) operator will take care of this in Perl 5.10 (right?)
  • Re: cheap profiler (Score:1)

    by phillup (4419)

    But note that 0 evaluates to false, so if you expect that as a legit value of $args{'hidden'}, this won't work.
    
    Hm... now that you mention it, mine won't either if the string is '0'.
    
    It isn't a problem in this specific instance... but I may need to actually use 'exists' on the value as a more 'generic' solution.
    
    • Re: cheap profiler (Score:1)

      by jplindstrom (594)

      You could always create a small utility function to keep things nice and tidy.

      sub definedOrEmpty {
          defined($_[0]) ? $_[0] : "";
      }

      or something like that.

      $form .= definedOrEmtpy( $args->{'hidden'} );

      Maybe a shorter name would be better. orEmpty perhaps. Whatever's clear in your situation.
• No such thing as a harmless warning. (Score:2)

  by schwern (1528)

  Also, 100% of the errors have to do with string concatenation, or comparison operators where I expect that values may be 'undef'.

  Classic mistake: Some of my code expects undef values so I ignore uninit warnings.

  Problem is the rest of your code doesn't expect undef warnings, in those spots getting an undef indicates a possible mistake. By ignoring uninit warnings for one part of the code you ignore problems in the rest. If a certain part of your code expects undefs write it so it handles them quietly
  • Re:No such thing as a harmless warning. (Score:1)

    by phillup (4419)

    Classic mistake: Some of my code expects undef values so I ignore uninit warnings.
    
    Actually, I am not ignoring any warnings. I added the use warnings pragma and it did what it was supposed to do... flagged possible problems.
    
    Then, I looked at each and every case and saw that they were all the same class of errors (concatenation of undefined variables or comparison with undefined data) and inspected each and every one and determined that none of them was a bug causing issue.
    
    Classic mistake: This warning i