BEGIN {
use base qw/Class::Accessor::Grouped/;
use Class::Inspector ();
use Scalar::Util ();
use Mango::Exception ();
__PACKAGE__->mk_group_accessors('component_class', qw/result_class/);
};
becomes
BEGIN {
use base qw/Class::Accessor::Grouped/;
use Class::Inspector ();
use Scalar::Util ();
use Mango::Exception ();
__PACKAGE__->mk_group_accessors('component_class',
qw/result_class/);
}
Nice work on the parans...but no reason to break that next line at all. -nanl fixes this problem, but leaves other lines of source way pas 80 columns. Sure, in this case, I can move qw/result_class/ to 'result_class' to avoid the formatting issue, but in other similiar code with more than on item in the qw//, it does the same thing. This is just one example of many issue I have. Things like stacking and not stacking closings. Somtimes it works. Sometimes, I get this:
sub delete {
my $self = shift;
return $self->meta->provider->delete_attributes(
$self->meta->parent,
{id => $self->id}
);
};
turned into this:
sub delete {
my $self = shift;
return $self->meta->provider->delete_attributes($self->meta->parent,
{id => $self->id});
}
Not an improvement in my book. My current setting work about 60% of the time. The rest of the time, the output seems worse to me.
-l=72
-i=4
-ci=4
-bar
-ce
-nsbl
-sot
-sct
-pt=2
-sbt=2
-bt=2
-bbt=2
-nsfs
-asc
-dsm
-nbbb
Thanx for ... Reinforcing my prejudices ... (Score:1)
It's about consistency (Score:1)
I sympathize with you on the list indentation, but I think your desire to have a line here and there
Re: (Score:1)