Slash Boxes
NOTE: use Perl; is on undef hiatus. You can read content, but you can't post it. More info will be forthcoming forthcomingly.

All the Perl that's Practical to Extract and Report

use Perl Log In

Log In

[ Create a new account ]

gav (2710)

  (email not shown publicly)
AOL IM: flufflegavin (Add Buddy, Send Message)

Hacker in NYC.

Journal of gav (2710)

Friday February 28, 2003
02:25 PM

what were thinking?

[ #10839 ]

Had to do some updates to a small cgi-script written by a co-worker and I found:

  1. Doesn't use
  2. Has the same if-elsif-else block copy and pasted four times but with slightly different numbers
  3. The very redundant $shipping += 0; statement
  4. Uses interesting quoting repeatedly - 'We\'re'
  5. Has code that doesn't match the comments:
    ##Perform Gift Cert Calc.##
    ##Free GiftCert Shipping with Stanard##
    $shipping += GIFTCERTSHIP * $GCcount;
  6. Gets the result wrong by forgetting that a line item can have a quantity
  7. Has a 96 line subroutine

I was going to excuse him if it was written a while back, but it's only 3 months old.

What do you do with a co-worker who seems to have no desire to improve his level of programming?

The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
More | Login | Reply
Loading... please wait.
  • Under the chair. It's the graceful thing to do.

    Seriously, talk to the manager. Tell them that the code is unmaintainable. Let them know.