I just woke from a dream where it was rjbs' birthday and we got him an onion cake. Only the person who made the cake misunderstood, and instead of a cake shaped like an onion he cooked it WITH onions in it.
Bizarro.
Can someone with Time::Piece test failures on Win32 please contact me offlist? I have a proposed patch I'd like to test, but no Win32 perl to test it on.
Never mind... It's just a buggette in the perl that ships with SL...
MEM_WRAP_CHECK_1 is defined as:
#define MEM_WRAP_CHECK_1(n,t,a) \
(void)(sizeof(t) > 1 && ((MEM_SIZE)(n)+0.0) > MEM_SIZE_MAX/sizeof(t) && (Perl_croak_nocontext(a),0))
Fix is to change it to:
#define MEM_WRAP_CHECK_1(n,t,a) \
(void)(sizeof(t) > 1 && ((MEM_SIZE)(n)+0.0) > MEM_SIZE_MAX/sizeof(t) && (Perl_croak_nocontext("%s",(a)),0))
Clang gives a few more details:
KQueue.xs:71:5: warning: format string is not a string literal (potentially insecure)
Newxz(ke, max_events, struct kevent);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/System/Library/Perl/5.10.0/darwin-thread- multi-2level/CORE/handy.h:776:28: note: instantiated from:
#define Newxz(v,n,t) (v = (MEM_WRAP_CHECK_(n,t) MEM_LOG_ALLOC(n,t,(t*)safecalloc((n),sizeof(t)))))
^
/System/Library/Perl/5.10.0/darwin-thread-multi-2level/CORE/handy.h:704:30: note: instantiated from:
#define MEM_WRAP_CHECK_(n,t) MEM_WRAP_CHECK(n,t),
^
/System/Library/Perl/5.10.0/darwin-thread-multi-2level/CORE/handy.h:701:29: note: instantiated from:
#define MEM_WRAP_CHECK(n,t) MEM_WRAP_CHECK_1(n,t,PL_memory_wrap)
^
I've searched but can't find any reference to this...
Compiling IO::KQueue on Snow Leopard I get the following warning:
KQueue.xs: In function 'XS_IO__KQueue_kevent':
KQueue.xs:71: warning: format not a string literal and no format arguments
Yet that line is just:
Newxz(ke, max_events, struct kevent);
Did I hear in my vague readings of p5p that this might be possible in 5.12?
If so, it'd be SO nice to have:
class Foo isa Bar {
method init(%options) {
$self->{some_key} = $options{some_key}// "default";
...
}
}
Personally I don't think it's really any cleaner. You've just hidden your meaning behind another statement, another module that the next maintainer has to go and read the docs for to figure out what it does. Sure it's a bit of extra typing, but you only do it once per file.
I had this argument with Ingy way back when he was coming up with YAML. He made it over complex (IMHO), resulting in a spec which made XML easier to implement than YAML (32 pages of spec vs nearly 200), which makes no sense since YAML was supposed to be EASIER to read and write than XML.
It's a bit more human readable than XML, but not much, and edge cases like this are going to make it a LOT harder to debug an issue with YAML than with XML.
Komodo Edit does the second thing there.
I know there's lots of things the IDE adds (there's a comparison table on ActiveState's site), but most of them wouldn't be very useful to me.
