use Perl

• uri_with (Score:2)

  by bart (450)

  Where is that function stored? I can imagine it to be useful for people who are not using Template Toolkit, and just use Data::Pager in their CGI scripts.
  • Re: (Score:1)

    by LTjake (4001)

    The function resides in Catalyst::Request [cpan.org]. Its utility is fairly dependent on the fact that we use a URI object for the request URL.

    Here's the relevant snippet:

    use utf8;
    use Carp;
    use URI::QueryParam;
    
    sub uri_with {
        my( $self, $args ) = @_;
    
        carp( 'No arguments passed to uri_with()' ) unless $args;
    
        for my $value ( values %$args ) {
            for ( ref $value eq 'ARRAY' ? @$value : $value ) {
                $_ = "$_";
     
    • Re: (Score:2)

      by bart (450)

      OK, silly question perhaps... Why do you do the hard work manually, why not make use of the method query_param_append [cpan.org]?
      • Re: (Score:1)

        by LTjake (4001)

        Unless i'm misunderstanding your point, I don't believe that method does what we're looking for. Example: say we have the following URL

        http://www.example.com/?q=test&page=2

        ...and we're generating the "next page" url. The following test script should show the two different methods:

        use strict;
        use warnings;
        
        use Test::More tests => 2;
        
        use URI;
        use URI::QueryParam;
        
        my $uri      = URI->new( 'http://example.com/?q=test&page=2' );
        my $expected = {
            q    => '
        • Re: (Score:2)

          by bart (450)

          Oh, if replacing instead of adding is what you want, then there are other methods that this module provides, such as query_param:

          If additional arguments are given, they are used to update successive parameters with the given key. If any of the values provided are array references, then the array is dereferenced to get the actual values.
          • Re: (Score:1)

            by Aristotle (5147)

            The point is you don’t have to construct a URI object. You just call uri_with and everything except the bits you want to override is already set up for you. Buf if you haven’t used an MVCish web app framework (even an ad-hoc one of your own device), you probably won’t appreciate why that’s so very useful.
            • Re: (Score:2)

              by bart (450)

              The point is you don’t have to construct a URI object.

              I'm not disputing that. I'm talking about the actual implementation of uri_with, which does create an object, and takes the long road to do it. It recreates every form parameter, instead of just adding new ones, and manually prepares every passed parameter for addition. This is a job the used module should have done.
• quotes (Score:1)

  by zby (4817)

  Shouldn't the 'page' param be quoted? Like: c.request.uri_with( 'page' => pager.next_page
  • Re: (Score:1)

    by LTjake (4001)

    Nope -- quotes are not strictly required. So says the examples in the docs [cpan.org], at least :)